linux-kernel - RE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00f34d2e88ab447bb13e0a19af3cf816@DFM-DB3MBX15-06.exchange.corp.microsoft.com>
Date:	Mon, 17 Mar 2014 20:59:33 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
Subject: RE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
 Side Scaling (vRSS)



> -----Original Message-----
> From: Ben Hutchings [mailto:ben@...adent.org.uk]
> Sent: Monday, March 17, 2014 4:28 PM
> To: Haiyang Zhang
> Cc: davem@...emloft.net; netdev@...r.kernel.org; KY Srinivasan;
> olaf@...fle.de; jasowang@...hat.com; linux-kernel@...r.kernel.org;
> driverdev-devel@...uxdriverproject.org
> Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
> 
> On Sat, 2014-03-15 at 10:18 -0700, Haiyang Zhang wrote:
> [...]
> >  #define RING_SIZE_MIN 64
> > -static int ring_size = 128;
> > +int ring_size = 128;
> >  module_param(ring_size, int, S_IRUGO);  MODULE_PARM_DESC(ring_size,
> > "Ring buffer size (# of pages)");
> 
> You have to add some driver-specific prefix to the variable name if it is going to
> be extern.  (And use module_param_named to avoid changing the parameter
> name too.)
> 
> [...]
> > +u8 hash_key[HASH_KEYLEN] = {
> > +	0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
> > +	0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
> > +	0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
> > +	0x77, 0xcb, 0x2d, 0xa3, 0x80, 0x30, 0xf2, 0x0c,
> > +	0x6a, 0x42, 0xb7, 0x3b, 0xbe, 0xac, 0x01, 0xfa };
> [...]
> 
> Same for this one.
> 
I will do.

Thanks,
- Haiyang