linux-kernel - Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Mar 2014 12:39:59 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings

On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote:
> Silences the following type of error/warnings:
> ERROR: that open brace { should be on the previous line
> WARNING: Missing a blank line after declarations

Applied, but...

> -	static const u8 max8660_addresses[MAX8660_N_REGS] =
> -	  { 0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 };
> +	static const u8 max8660_addresses[MAX8660_N_REGS] = {
> +	  0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 };

Think about what you're doing here - you want the }; on a new line too.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)