linux-kernel - Re: [PATCH 3/8] regulator: arizona-ldo1: Move setup processing from arizona-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140318141142.GC1665@opensource.wolfsonmicro.com>
Date:	Tue, 18 Mar 2014 14:11:42 +0000
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rob@...dley.net, sameo@...ux.intel.com, lee.jones@...aro.org,
	lgirdwood@...il.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] regulator: arizona-ldo1: Move setup processing
	from arizona-core

On Tue, Mar 18, 2014 at 11:10:49AM +0000, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 10:49:12AM +0000, Charles Keepax wrote:
> 
> > +#ifdef CONFIG_OF
> > +static int arizona_ldo1_get_pdata(struct arizona *arizona,
> > +				  struct regulator_config *config)
> > +{
> > +	arizona_of_get_named_gpio(arizona, "wlf,ldoena", true,
> > +				  &config->ena_gpio);
> > +
> > +	return 0;
> > +}
> > +#else
> > +static inline int arizona_ldo1_get_pdata(struct arizona *arizona,
> > +					 struct regulator_config *config)
> > +{
> > +	struct arizona_pdata *pdata = &arizona->pdata;
> > +
> > +	config->ena_gpio = arizona->pdata.ldoena;
> 
> This breaks non-DT systems booting a kernel which has DT support
> compiled in.  It's also more than simple code motion which is what the
> changelog claimed this was doing.

Oops.. sorry that is a good point I will respin these.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/