linux-kernel - Re: [PATCH] tools, perf: Add asprintf replacement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140318150533.GA3132@tassilo.jf.intel.com>
Date:	Tue, 18 Mar 2014 08:05:33 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	Andi Kleen <andi@...stfloor.org>, mingo@...nel.org,
	linux-kernel@...r.kernel.org, peterz@...radead.org,
	eranian@...gle.com, namhyung@...nel.org, jolsa@...hat.com
Subject: Re: [PATCH] tools, perf: Add asprintf replacement

> Humm, this unconditionally replaces it with an alternative that limits
> the buffer to a fixed size :-\

Better than corrupting memory.

I guess you could use two passes to avoid the limit, but it would surprise me
if anything in perf needs more than 1K of printf. One issue 
with doing two passes is that I wasn't sure the snprintf return
value would work properly on all libcs (e.g. the weirdo one Android uses)

> 
> Do you recall at least one of those old glibc version/release number?

glibc-2.13-2.x86_64 (FC14)

> 
> A reproducer? So that I can try to reproduce it here and try to polish
> this a bit more...

I saw it with perf report --branch-history in TUI mode and then pressing
e. But even running valgrind in stdio mode showed some corruption.
Without the patch also using some of the --call-graph options segfaulted.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/