linux-kernel - Re: [patch 01/12] can: c_can: Wait for CONTROL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403181918380.18573@ionos.tec.linutronix.de>
Date:	Tue, 18 Mar 2014 19:19:30 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Markus Pargmann <mpa@...gutronix.de>,
	Benedikt Spranger <b.spranger@...utronix.de>,
	linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 01/12] can: c_can: Wait for CONTROL_INIT to be cleared

On Tue, 18 Mar 2014, Marc Kleine-Budde wrote:
> On 03/18/2014 06:19 PM, Thomas Gleixner wrote:
> > According to the documentation the CPU must wait for CONTROL_INIT to
> > be cleared before writing to the baudrate registers.
> 
> Thanks for the catch.
> > +	return c_can_wait_for_ctrl_init(dev, priv, 0);
> 
> I'll post a patch that adds return value checking of all direct and
> indirect users of c_can_set_bittiming().

Right, I forgot to mention, that an error return gets lost in lala
land.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/