lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1395170800-11059-1-git-send-email-vgoyal@redhat.com>
Date:	Tue, 18 Mar 2014 15:26:35 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	linux-kernel@...r.kernel.org, hpa@...or.com
Cc:	Vivek Goyal <vgoyal@...hat.com>
Subject: [PATCH 0/5] x86/boot: Some string function cleanup and consolidation

Hi Peter,

I have tried cleaning up a bit the usage of string functions in arch/x86/boot/.

I have created x86/boot/string.h which all the callers can include and by
default they get the built in definition of memcpy, memset and memcmp. Those
who want to use optimized version of these functions, need to #undef respective
macro and link again the approprate string.c file which provides the function
definition.

After this change I am planning to include x86/boot/string.h in purgatory
code and get built-in definitions of memcpy, memset and memcmp.

There seem to be lot of magic going on in arch/x86/boot/. I do not claim
to understand it all. Hopefully above changes do not break anything.

Please have a look.

Thanks
Vivek


Vivek Goyal (5):
  x86/boot: undef memcmp before providing a new definition
  x86/boot: Create a separate string.h file to provide standard string
    functions
  x86/boot: Move optmized memcpy() 32/64 bit versions to
    compressed/string.c
  x86/boot: Move memcmp() into string.h and string.c
  x86/boot: Move memset() definition in compressed/string.c

 arch/x86/boot/boot.h              | 13 ----------
 arch/x86/boot/compressed/misc.c   | 51 ++++++---------------------------------
 arch/x86/boot/compressed/string.c | 46 ++++++++++++++++++++++++++++++-----
 arch/x86/boot/cpucheck.c          |  1 +
 arch/x86/boot/edd.c               |  1 +
 arch/x86/boot/main.c              |  1 +
 arch/x86/boot/regs.c              |  1 +
 arch/x86/boot/string.c            | 14 +++++++++++
 arch/x86/boot/string.h            | 21 ++++++++++++++++
 arch/x86/boot/video-vesa.c        |  1 +
 10 files changed, 88 insertions(+), 62 deletions(-)
 create mode 100644 arch/x86/boot/string.h

-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ