linux-kernel - Re: [PATCH] drm/i915: Do not dereference pointers from ring buffer in evict event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140318195007.GJ30571@phenom.ffwll.local>
Date:	Tue, 18 Mar 2014 20:50:07 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Ben Widawsky <ben@...dawsk.net>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	Ramkumar Ramachandra <artagnon@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] drm/i915: Do not dereference pointers from ring buffer
 in evict event

On Tue, Mar 18, 2014 at 11:31:36AM -0400, Steven Rostedt wrote:
> On Tue, 18 Mar 2014 11:27:37 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > The TP_printk() should never dereference any pointers, because the ring
> > buffer can be read at some unknown time in the future. If a device no
> > longer exists, it can cause a kernel oops. This also makes this
> > event useless when saving the ring buffer in userspaces tools such as
> > perf and trace-cmd.
> > 
> > The i915_gem_evict_vm dereferences the vm pointer which may also not
> > exist when the ring buffer is read sometime in the future.
> > 
> > Link: http://lkml.kernel.org/r/1395095198-20034-3-git-send-email-artagnon@gmail.com
> > Reported-by: Ramkumar Ramachandra <artagnon@...il.com> Cc:
> > stable@...r.kernel.org # 3.13+
> 
> Bah, claw's mail is playing havoc with my line wraps. Please fix the
> above when applying, or I can send anothe patch. Thanks :-)
> 
> I had to re-insert the patch due to it but didn't see the screw up with
> the Cc of stable.

Patch applied and cc: stable fixed, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/