linux-kernel - Re: [PATCH] staging: slicoss: Fix prefer ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395114498.20860.4.camel@joe-AO722>
Date:	Mon, 17 Mar 2014 20:48:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Joel Pelaez Jorge' <joelpelaez@...il.com>,
	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	'Rashika Kheria' <rashika.kheria@...il.com>,
	'Peter P Waskiewicz Jr' <peter.p.waskiewicz.jr@...el.com>,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	'Wei Yongjun' <yongjun_wei@...ndmicro.com.cn>,
	'Dan Carpenter' <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

On Tue, 2014-03-18 at 12:38 +0900, Jingoo Han wrote:
> In addition to this, there are the same cases like this,
> in this file as below. Please search other same cases.
> For instance, 'grep' will be a good way to find it.
[]
> static void slic_adapter_set_hwaddr(struct adapter *adapter)
> {
>         struct sliccard *card = adapter->card;
[]
>                 if (is_zero_ether_addr(adapter->currmacaddr))
>                         memcpy(adapter->currmacaddr, adapter->macaddr,
>                                ETH_ALEN);
>                 if (adapter->netdev)
>                         memcpy(adapter->netdev->dev_addr, adapter->currmacaddr,
>                                ETH_ALEN);
>         }
> }
> 
> Joe Perches,
> These are not spotted by checkpatch.pl.
> However, after modifying it as below, checkpatch warnings are
> printed. Would you confirm it?

If it's not on a single line, checkpatch won't find it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/