linux-kernel - Re: [PATCH 1/1] MINIX: specific inode data access standardization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140318142531.ebb7f50ed458df868d64cf10@linux-foundation.org>
Date:	Tue, 18 Mar 2014 14:25:31 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] MINIX: specific inode data access standardization

On Tue, 18 Mar 2014 18:52:21 +0100 Fabian Frederick <fabf@...net.be> wrote:

> minix_i uppercase conversion (like majority of other filesystems).
>
> ...
>
> @@ -255,7 +255,7 @@ struct inode *minix_new_inode(const struct inode *dir, umode_t mode, int *error)
>  	inode->i_ino = j;
>  	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
>  	inode->i_blocks = 0;
> -	memset(&minix_i(inode)->u, 0, sizeof(minix_i(inode)->u));
> +	memset(&MINIX_I(inode)->u, 0, sizeof(MINIX_I(inode)->u));
>  	insert_inode_hash(inode);
>  	mark_inode_dirty(inode);

minix is correct and the other filesystems are wrong.

minix_i() is a regular C function.  There is no earthly reason why it
should be all-caps.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/