linux-kernel - Re: [PATCH] staging/xillybus: Handle OOM in xillybus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <5328D44D.9060509@gmail.com>
Date:	Wed, 19 Mar 2014 01:18:37 +0200
From:	Eli Billauer <eli.billauer@...il.com>
To:	Richard Weinberger <richard@....at>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/xillybus: Handle OOM in xillybus_init()

Hi,

I stand (shamefully) corrected. Thanks.

   Eli

On 19/03/14 01:07, Richard Weinberger wrote:
> alloc_workqueue() can fail and returns NULL in case of
> OOM.
> Handle this case and undo class_create().
>
> Signed-off-by: Richard Weinberger<richard@....at>
> ---
>   drivers/staging/xillybus/xillybus_core.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c
> index 2ebaf16..b0a6696 100644
> --- a/drivers/staging/xillybus/xillybus_core.c
> +++ b/drivers/staging/xillybus/xillybus_core.c
> @@ -2318,8 +2318,12 @@ static int __init xillybus_init(void)
>   	}
>
>   	xillybus_wq = alloc_workqueue(xillyname, 0, 0);
> +	if (!xillybus_wq) {
> +		class_destroy(xillybus_class);
> +		rc = -ENOMEM;
> +	}
>
> -	return 0; /* Success */
> +	return rc;
>   }
>
>   static void __exit xillybus_exit(void)
>    


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/