| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAK9yfHwNmN+M8ncSGjUwnfXs1p-e7pCy5Y-K7uX6JV5JyWYhEg@mail.gmail.com> Date: Wed, 19 Mar 2014 13:57:35 +0530 From: Sachin Kamat <sachin.kamat@...aro.org> To: Krzysztof Kozlowski <k.kozlowski@...sung.com> Cc: Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] mfd: sec-core: Fix uninitialized 'regmap_rtc' on S2MPA01 On 18 March 2014 18:41, Krzysztof Kozlowski <k.kozlowski@...sung.com> wrote: > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > rtc-s5m driver does not support S2MPA01. > > This fixes following error: > drivers/mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used uninitialized in this function [-Wuninitialized] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> >From the point of suppressing this warning and considering how it is done for S2MPS11, Acked-by: Sachin Kamat <sachin.kamat@...aro.org> However, shouldn't we be making this RTC handling conditional/optional depending upon whether the h/w or s/w supports/implements it? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists