linux-kernel - Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using the name of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <532988DA.8030002@ti.com>
Date:	Wed, 19 Mar 2014 17:38:58 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Chanwoo Choi <cw00.choi@...sung.com>, <gregkh@...uxfoundation.org>,
	<balbi@...com>, <myungjoo.ham@...sung.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/2] extcon: of: Remove unnecessary function call by using
 the name of device_node

Hi,

On Tuesday 18 March 2014 05:34 PM, Chanwoo Choi wrote:
> This patch remove unnecessary function call in of_extcon_get_extcon_dev()
> by using the name of device_node structure.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/of_extcon.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/extcon/of_extcon.c b/drivers/extcon/of_extcon.c
> index 72173ec..0a29f82 100644
> --- a/drivers/extcon/of_extcon.c
> +++ b/drivers/extcon/of_extcon.c
> @@ -32,7 +32,6 @@ struct extcon_dev *of_extcon_get_extcon_dev(struct device *dev, int index)
>  {
>  	struct device_node *node;
>  	struct extcon_dev *edev;
> -	struct platform_device *extcon_parent_dev;
>  
>  	if (!dev->of_node) {
>  		dev_dbg(dev, "device does not have a device node entry\n");
> @@ -46,16 +45,9 @@ struct extcon_dev *of_extcon_get_extcon_dev(struct device *dev, int index)
>  		return ERR_PTR(-ENODEV);
>  	}
>  
> -	extcon_parent_dev = of_find_device_by_node(node);
> -	if (!extcon_parent_dev) {
> -		dev_dbg(dev, "unable to find device by node\n");
> -		return ERR_PTR(-EPROBE_DEFER);
> -	}
> -
> -	edev = extcon_get_extcon_dev(dev_name(&extcon_parent_dev->dev));
> +	edev = extcon_get_extcon_dev(node->name);

Since you no longer want to use device names I think you should add this too to
warn users if they rely on using the device name.
diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index bc4c789..025eb39 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -601,7 +601,6 @@ int extcon_dev_register(struct extcon_dev *edev)
        edev->dev.class = extcon_class;
        edev->dev.release = extcon_dev_release;

-       edev->name = edev->name ? edev->name : dev_name(edev->dev.parent);
//The user should always pass the 'name' as we no longer use device name while
getting extcon device. And this name should also be the 'node' name?
        if (IS_ERR_OR_NULL(edev->name)) {
                dev_err(&edev->dev,
                        "extcon device name is null\n");

Btw changing to node name from device name breaks dwc3 in OMAP5 and you would
need this too..

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 2aea4bc..cea8cd3 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -188,6 +188,7 @@ static int palmas_usb_probe(struct platform_device *pdev)

        palmas_usb->edev.supported_cable = palmas_extcon_cable;
        palmas_usb->edev.dev.parent = palmas_usb->dev;
+       palmas_usb->edev.name = "palmas_usb";
        palmas_usb->edev.mutually_exclusive = mutually_exclusive;

        status = extcon_dev_register(&palmas_usb->edev);

Cheers
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/