lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140319010436.GA19180@kroah.com>
Date:	Tue, 18 Mar 2014 18:04:36 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mathieu Maret <mathieu.maret@...il.com>
Cc:	pe1dnn@...at.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlags49_h2: Coding style correction

On Wed, Mar 19, 2014 at 01:52:09AM +0100, Mathieu Maret wrote:
> As the file was mixing tab and space, reindent the file
> Mainly correct use of C99 comments,
> space between parenthesis,
> remove commented code
> 
> Signed-off-by: Mathieu Maret <mathieu.maret@...il.com>
> ---
>  drivers/staging/wlags49_h2/wl_netdev.c | 1990 ++++++++++++++++----------------
>  1 file changed, 1007 insertions(+), 983 deletions(-)

That's way too big to review easily, can you do that?  :)

Please break it up into "do one thing at a time" type patch, so that it
can be reviewed and applied properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ