linux-kernel - Re: [PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1395233441.15174.8.camel@AMDC1943>
Date:	Wed, 19 Mar 2014 13:50:41 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Sangbeom Kim <sbkim73@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>
Subject: Re: [PATCH-next] mfd/rtc: s5m: Do not allocate RTC I2C dummy and
 regmap for unsupported chipsets

On Wed, 2014-03-19 at 12:47 +0000, Lee Jones wrote:
> > The rtc-s5m driver does not support all of S2M and S5M chipsets
> > supported by main MFD sec-core driver. For such chipsets unsupported by
> > rtc-s5m, the MFD sec-core driver initialized regmap with default config.
> > This config in such cases wouldn't work at all.
> > 
> > The main MFD sec-core driver shouldn't initialize regmap for child
> > drivers which is not used by them and even not valid.
> > 
> > Move the allocation of RTC I2C dummy device and initialization of RTC
> > regmap from main MFD sec-core driver to the rtc-s5m driver. The rtc-s5m
> > driver will use proper regmap config for supported devices.
> > 
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > ---
> >  drivers/mfd/sec-core.c           |   53 +--------------------------
> >  drivers/rtc/rtc-s5m.c            |   75 +++++++++++++++++++++++++++++++++++---
> >  include/linux/mfd/samsung/core.h |    3 --
> >  3 files changed, 71 insertions(+), 60 deletions(-)
> 
> It's a bit late in the cycle for this kind of change. Would you mind
> re-sending after the v3.15 merge window please?

Sure, no problem.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/