linux-kernel - Re: [PATCH] Coccicheck: Remove memcpy to struct assignment test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2014 14:39:49 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	Bernd Petrovitsch <bernd@...rovitsch.priv.at>
Cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>, mmarek@...e.cz,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cocci@...teme.lip6.fr" <cocci@...teme.lip6.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andreea Bernat <bernat.ada@...il.com>,
	Ezequiel Garcia <elezegarcia@...il.com>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Coccicheck: Remove memcpy to struct assignment test

On Wed, Mar 19, 2014 at 1:02 PM, Bernd Petrovitsch
<bernd@...rovitsch.priv.at> wrote:
> On Die, 2014-03-18 at 22:11 +0100, Peter Senna Tschudin wrote:
>> The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
>> for opportunities to replace a call to memcpy by a struct assignment.
>> This patch removes memcpy-assign.cocci as it is not clear that this
>> convention has an impact on the generated code.
>
> Using struct assignment keeps the type check and is just for this reason
> always preferable over memcpy().
What about the assignment hiding that a potentially large memcpy is
happening instead of just a pointer assignment?

>
> Kind regards,
>         Bernd
> --
> Bernd Petrovitsch                  Email : bernd@...rovitsch.priv.at
>                      LUGA : http://www.luga.at
>



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/