linux-kernel - Re: [PATCH 4/5] staging: wlags49_h2: Correct macro style in wl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140319153637.GA19407@kroah.com>
Date:	Wed, 19 Mar 2014 08:36:37 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mathieu Maret <mathieu.maret@...il.com>
Cc:	pe1dnn@...at.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] staging: wlags49_h2: Correct macro style in
 wl_netdev.c

On Wed, Mar 19, 2014 at 09:20:34AM +0100, Mathieu Maret wrote:
> Multi statement macro should use do{}while(0)
> 
> Signed-off-by: Mathieu Maret <mathieu.maret@...il.com>
> ---
>  drivers/staging/wlags49_h2/wl_netdev.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c
> index 255d291..6455956 100644
> --- a/drivers/staging/wlags49_h2/wl_netdev.c
> +++ b/drivers/staging/wlags49_h2/wl_netdev.c
> @@ -107,9 +107,11 @@
>   * macros
>   ******************************************************************************/
>  #define BLOCK_INPUT(buf, len) \
> -    desc->buf_addr = buf; \
> -    desc->BUF_SIZE = len; \
> -    status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0)
> +	do { \
> +		desc->buf_addr = buf; \
> +		desc->BUF_SIZE = len; \
> +		status = hcf_rcv_msg(&(lp->hcfCtx), desc, 0) \
> +	} while (0)
>  
>  #define BLOCK_INPUT_DMA(buf, len) memcpy( buf, desc_next->buf_addr, pktlen )
>  

You didn't test-build the code after making this change, as this patch
breaks the build into lots of tiny pieces :(

Please ALWAYS test your patches.

I've applied the first 3 patches, please fix this one up (if it's even
possible, hint, I don't think it is...) and resend the remaining
patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/