linux-kernel - Re: [PATCH RFC] sched: introduce add_wait_queue_exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140319165747.GC8557@laptop.programming.kicks-ass.net>
Date:	Wed, 19 Mar 2014 17:57:47 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Peng Tao <bergwolf@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH RFC] sched: introduce add_wait_queue_exclusive_head

On Wed, Mar 19, 2014 at 05:49:07PM +0100, Oleg Nesterov wrote:
> +static void add_wait_queue_flag(wait_queue_head_t *q, wait_queue_t *wait)
> +{
> +	struct list_head *head = &q->task_list;
> +	wait_queue_t *excl;
> +
> +	if (wait->flags & WQ_FLAG_EXCLUSIVE) {
> +		if (wait->flags & WQ_FLAG_EXCLUSIVE_HEAD) {
> +			list_for_each_entry(excl, head, task_list)
> +				if (excl->flags & WQ_FLAG_EXCLUSIVE) {
> +					head = &excl->task_list;
> +					break;
> +				}

I prefer an extra pair of { } here, but the main concern would be the
cost of that iteration.

> +		}
> +		/* turn list_add() below into list_add_tail() */
> +		head = head->prev;
> +	}
> +
> +	list_add(&wait->task_list, head);
> +}

Other than that, yes something like that would do I suppose.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/