linux-kernel - RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d2b00238de54faaa290f375dd55eead@BN1PR03MB251.namprd03.prod.outlook.com>
Date:	Wed, 19 Mar 2014 18:03:05 +0000
From:	"suresh.gupta@...escale.com" <suresh.gupta@...escale.com>
To:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"balbi@...com" <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform
 device id

Hi Ramneek,

Do you understand, what Greg want to communicate. 


Thanks
SuresH

> -----Original Message-----
> From: gregkh@...uxfoundation.org [mailto:gregkh@...uxfoundation.org]
> Sent: Wednesday, March 19, 2014 10:22 PM
> To: Gupta Suresh-B42813
> Cc: balbi@...com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> platform device id
> 
> On Wed, Mar 19, 2014 at 02:25:25PM +0000, suresh.gupta@...escale.com
> wrote:
> > Hi
> >
> > > -----Original Message-----
> > > From: Felipe Balbi [mailto:balbi@...com]
> > > Sent: Saturday, March 15, 2014 7:10 AM
> > > To: Gupta Suresh-B42813
> > > Cc: balbi@...com; gregkh@...uxfoundation.org;
> > > linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
> > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > platform device id
> > >
> > > On Fri, Mar 14, 2014 at 08:52:19PM +0000, suresh.gupta@...escale.com
> > > wrote:
> > > > Hi,
> > > > Thanks for reviewing my patches.
> > > > Please find my comments inline
> > > >
> > > > -----Original Message-----
> > > > From: Felipe Balbi [mailto:balbi@...com]
> > > > Sent: Thursday, March 13, 2014 8:56 PM
> > > > To: Gupta Suresh-B42813
> > > > Cc: balbi@...com; gregkh@...uxfoundation.org;
> > > > linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Gupta
> > > > Suresh-B42813
> > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in
> > > > platform device id
> > > >
> > > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote:
> > > > > From: Suresh Gupta <B42813@...escale.com>
> > > > >
> > > > > 	Add FSL USB Gadget entry in platform device id table
> > > >
> > > > why this tab ?
> > > > [SuresH] I will remove it in next version.
> > > >
> > > > > Signed-off-by: Suresh Gupta <B42813@...escale.com>
> > > > > ---
> > > > >  drivers/usb/gadget/fsl_udc_core.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c
> > > > > b/drivers/usb/gadget/fsl_udc_core.c
> > > > > index b7dea4e..35b20e6 100644
> > > > > --- a/drivers/usb/gadget/fsl_udc_core.c
> > > > > +++ b/drivers/usb/gadget/fsl_udc_core.c
> > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > fsl_udc_devtype[] = {
> > > > >  	}, {
> > > > >  		.name = "imx-udc-mx51",
> > > > >  	}, {
> > > > > +		.name = "fsl-usb2-udc",
> > > >
> > > > why aren't you just using chipidea ?
> > > > [SuresH] This is our legacy driver for all previous and existing
> > > > ppc socs. Many of our customers are already using this, and we
> > > > need to support them on this driver. We do have plans to shift to
> > > > chipidea, but after some time.
> > >
> > > cool, you already have plans, so we will see a new glue layer for
> > > v3.16 right ? Which means I don't need to take this patch either.
> > >
> > we do have plans, but in remote future. Right now, we need to support
> > customers on the present legacy driver. We'll phase out this driver
> > slowly when we integrate chipidea. At this time I would request you to
> > please accept this patch
> 
> Even if Felipe takes the patch, I'll reject it as you should be doing the
> correct thing here, and if it's accepted, it will never be changed...
> 
> greg k-h
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/