linux-kernel - Re: Stricter module param and sysfs permission checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVxJT_WnkoUVxcLoraBAGpMB9jMaOqg8SY27RPLuym55o4J4Q@mail.gmail.com>
Date:	Thu, 20 Mar 2014 12:15:48 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Dave Jones <davej@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Joe Perches <joe@...ches.com>, "Theodore Ts'o" <tytso@....edu>,
	Linux Kernel Developers List <linux-kernel@...r.kernel.org>,
	fes@...gle.com, Bjorn Helgaas <bhelgaas@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Simon Wood <simon@...gewell.org>
Subject: Re: Stricter module param and sysfs permission checks

On Thu, Mar 20, 2014 at 7:27 AM, Dave Jones <davej@...hat.com> wrote:
> On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote:
>
>  > drivers/mtd/devices/docg3.c:
>  >      __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \
>  >      __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \
>  >
>  > drivers/scsi/pm8001/pm8001_ctl.c:
>  > static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUGO,
>  >      pm8001_show_update_fw, pm8001_store_update_fw);
>
> Why on earth are these world writable ?

Yup.

I like new and improved checks.
Rusty, add my "& 2" check everywhere!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/