lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 20 Mar 2014 13:16:51 +0100
From:	Thomas Graf <>
To:	Zoltan Kiss <>,
	Jesse Gross <>,,
CC:	"David S. Miller" <>,
	Pablo Neira Ayuso <>,
	Jozsef Kadlecsik <>,
	Eric Dumazet <>,
	Daniel Borkmann <>,
	Tom Herbert <>,
	Jason Wang <>,
	Florian Westphal <>, Joe Perches <>,
	Simon Horman <>,
	Jiri Pirko <>,
	"Michael S. Tsirkin" <>,
	Paul Durrant <>,
	Jan Beulich <>,
	Herbert Xu <>,
	Miklos Szeredi <>,,,,,,
Subject: Re: [PATCH v2] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy
 and handle errors

On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well.
> Signed-off-by: Zoltan Kiss <>

Acked-by: Thomas Graf <>

> ---
> +	if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
> +		skb_tx_error(to);
> +		return -ENOMEM;
> +	}

Did you consider calling skb_tx_error() for Netlink message
allocation failures for the upcall as well? That memory pressure
is currently not reported back.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists