| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Mar 2014 13:29:42 +0000 From: Lee Jones <lee.jones@...aro.org> To: Joe Perches <joe@...ches.com> Cc: Brian Norris <computersforpeace@...il.com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kernel@...inux.com, linux-mtd@...ts.infradead.org, dwmw2@...radead.org, angus.clark@...com Subject: Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments > > > Good catch. That wasn't my intention. > > > > Why? > > An oversight. > > That's still not an explanation. > > Why, unless cast away by the code itself, is > const removal a good thing? > > It does serve as an indication to a reader what > the code does with the argument. > > About the only reason I can think of arguing in > favor of removal is inconsistent application of > const within the module. Your qualm is not with me in this instance. I don't ever mind holding my hands up to mistakes I make or standing up for decisions I believe in, but in this case I'm merely satisfying the wishes of a maintainer I'm submitting code to. I am strongly un-opinionated about these particular changes. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists