linux-kernel - Re: [PATCH] tty: serial: sc16is7xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140320140848.GB23372@e106331-lin.cambridge.arm.com>
Date:	Thu, 20 Mar 2014 14:08:48 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	"jon@...gle.org" <jon@...gle.org>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"shc_work@...l.ru" <shc_work@...l.ru>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jon Ringle <jringle@...dpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx

On Thu, Mar 20, 2014 at 02:02:57PM +0000, jon@...gle.org wrote:
> From: Jon Ringle <jringle@...dpoint.com>
> 
> The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
> high performance UART. The SC16IS7xx’s internal register set is
> backward-compatible with the widely used and widely popular 16C450.
> 
> The SC16IS7xx also provides additional advanced features such as
> auto hardware and software flow control, automatic RS-485 support, and
> software reset.
> 
> Signed-off-by: Jon Ringle <jringle@...dpoint.com>
> ---
>  drivers/tty/serial/Kconfig       |   10 +
>  drivers/tty/serial/Makefile      |    1 +
>  drivers/tty/serial/sc16is7xx.c   | 1258 ++++++++++++++++++++++++++++++++++++++
>  include/uapi/linux/serial_core.h |    3 +
>  4 files changed, 1272 insertions(+)
>  create mode 100644 drivers/tty/serial/sc16is7xx.c

[...]

> +static const struct of_device_id __maybe_unused sc16is7xx_dt_ids[] = {
> +       { .compatible = "nxp,sc16is740",        .data = &sc16is74x_devtype, },
> +       { .compatible = "nxp,sc16is741",        .data = &sc16is74x_devtype, },
> +       { .compatible = "nxp,sc16is750",        .data = &sc16is750_devtype, },
> +       { .compatible = "nxp,sc16is752",        .data = &sc16is752_devtype, },
> +       { .compatible = "nxp,sc16is760",        .data = &sc16is760_devtype, },
> +       { .compatible = "nxp,sc16is762",        .data = &sc16is762_devtype, },
> +       { }
> +};

Please document these strings (even if under a trivial binding
document).

Cheers,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/