linux-kernel - Re: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <532B022C.8010505@broadcom.com>
Date:	Thu, 20 Mar 2014 15:58:52 +0100
From:	Arend van Spriel <arend@...adcom.com>
To:	Monam Agarwal <monamagarwal123@...il.com>, <netdev@...r.kernel.org>
CC:	<linux-kernel@...r.kernel.org>, <eddie.wai@...adcom.com>,
	<paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 0/9] Replace rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)

On 20/03/14 15:37, Monam Agarwal wrote:
> This patchset uses following coccinelle script to replace
> rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x,NULL)
>
> @@
> expression E;
> @@
> - rcu_assign_pointer(
> + RCU_INIT_POINTER(
> E, NULL)

I am not very familiar with rcu functionality nor coccinelle, but it 
looks too generic. I would think only NULL assignments during 
initialization should use RCU_INIT_POINTER(). The first patch in the 
series does it in a function called unregister_...(). Is it really ok to 
do there?

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/