linux-kernel - Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Mar 2014 16:03:26 +0000
From:	Grant Likely <grant.likely@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Rob Herring <robh+dt@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

On Thu, 13 Mar 2014 11:35:28 +0000, Russell King - ARM Linux <linux@....linux.org.uk> wrote:
> On Thu, Mar 13, 2014 at 12:08:16PM +0100, Philipp Zabel wrote:
> > I'm not sure if maybe I misunderstood or missed a mail, but I haven't
> > seen a proposal to resolve the situation without rewinds. Given that
> > Mauro already reverted the media tree and applied conflicting changes,
> > that's probably not going to happen?
> 
> Grant and myself have exchanged emails in private on this discussing what
> should happen - essentially Grant's position is that he's happy to leave
> this stuff queued provided a resolution to his concerns are forthcoming.
> 
> However, what I find incredibly unfair is that we're taking the rap for
> these bad bindings.  From what I can see, these bad bindings were merged
> into the V4L2 code with _zero_ review by DT maintainers.  It's quite
> clear that DT maintainers would have objected to them had they seen them,
> but they didn't.  And the lack of documentation of the bindings which
> has been something that's been insisted on is also disgusting.

When a binding is limited to a single driver, review isn't critical.
When it is local to a single subsystem the bar is a little higher. Yes,
it should have had more review, but the surface area is still minimal.
By turning the binding into a generic pattern that all subsystems are
welcome to use the bar becomes higher still. It is not unreasonable for
a binding a new round of review when it is being adapted to become more
generic.

V4L2 can and should continue to use what it has. It certainly is not
okay to break existing platforms. All of my issues are directed toward
new users.

Despite my concerns, I do want this series to get merged in the next
merge window.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/