linux-kernel - Re: [PATCH] jump label: constify lookup functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Mar 2014 13:13:52 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jump label: constify lookup functions

On Fri, 14 Mar 2014 15:40:05 -0400
Sasha Levin <sasha.levin@...cle.com> wrote:

> ping?
> 
> On 02/12/2014 08:56 AM, Sasha Levin wrote:
> > ping?
> >
> > On 01/27/2014 02:27 PM, Sasha Levin wrote:
> >> Modify the parameters of all the lookup and the bookkeeping functions which
> >> should be const to const.
> >>
> >> For example, jump_label_text_reserved() doesn't modify the memory it works on,
> >> it just checks whether there are any jump labels there.
> >>
> >> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> >> ---
> >>   arch/arm/include/asm/jump_label.h     |  2 +-
> >>   arch/arm/kernel/jump_label.c          |  6 ++---
> >>   arch/arm64/include/asm/jump_label.h   |  2 +-
> >>   arch/arm64/kernel/jump_label.c        |  6 ++---
> >>   arch/mips/include/asm/jump_label.h    |  2 +-
> >>   arch/mips/kernel/jump_label.c         |  2 +-
> >>   arch/powerpc/include/asm/jump_label.h |  2 +-
> >>   arch/powerpc/kernel/jump_label.c      |  2 +-
> >>   arch/s390/include/asm/jump_label.h    |  2 +-
> >>   arch/s390/kernel/jump_label.c         | 12 ++++-----
> >>   arch/sparc/include/asm/jump_label.h   |  2 +-
> >>   arch/sparc/kernel/jump_label.c        |  2 +-
> >>   arch/x86/include/asm/jump_label.h     |  2 +-
> >>   arch/x86/include/asm/spinlock.h       |  2 +-
> >>   arch/x86/kernel/jump_label.c          |  6 ++---

The arch changes should be broken up per arch. They are not dependent
on each other, and they require being either acked by or pulled in by
the architecture maintainers.

> >>   include/linux/jump_label.h            | 27 ++++++++++----------
> >>   kernel/jump_label.c                   | 46 ++++++++++++++++++-----------------
> >>   17 files changed, 64 insertions(+), 61 deletions(-)

The jump label generic patch should also be by itself, and that I can
take.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/