linux-kernel - Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <532B2540.8050601@fastmail.fm>
Date:	Thu, 20 Mar 2014 18:28:32 +0100
From:	Bernd Schubert <bernd.schubert@...tmail.fm>
To:	"Reddy, Sreekanth" <Sreekanth.Reddy@....com>, jejb@...nel.org,
	JBottomley@...allels.com
CC:	linux-scsi@...r.kernel.org, Sathya.Prakash@....com,
	Nagalakshmi.Nandigama@....com, linux-kernel@...r.kernel.org,
	sreekanthreddy0547@...il.com
Subject: Re: [PATCH 02/11][SCSI]mpt2sas: Added new driver module Parameter
 disable_eedp to Disable EEDP Support

>   	u8		scsi_io_cb_idx;
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index 7f0af4f..d502728 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -127,6 +127,11 @@ static int disable_discovery = -1;
>   module_param(disable_discovery, int, 0);
>   MODULE_PARM_DESC(disable_discovery, " disable discovery ");
>
> +/* Enable or disable EEDP support */
> +static int disable_eedp;
> +module_param(disable_eedp, uint, 0);
> +MODULE_PARM_DESC(disable_eedp, " disable EEDP support: (default=0)");

Wouldn't it make sense to exlain what EEDP means? Something like

MODULE_PARM_DESC(disable_eedp,
		" disable end-to-end data protection support (DIF): "
		"default=0)");



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/