linux-kernel - Re: hci_ldsic nested locking problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140320173518.GD2827@saruman.home>
Date:	Thu, 20 Mar 2014 12:35:18 -0500
From:	Felipe Balbi <balbi@...com>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	<balbi@...com>, Alan Cox <alan@...ux.intel.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Muralidharan Karicheri <m-karicheri2@...com>,
	<linux-bluetooth@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Huang Shijie <b32955@...escale.com>
Subject: Re: hci_ldsic nested locking problem

On Thu, Mar 20, 2014 at 01:34:57PM -0400, Peter Hurley wrote:
> [ +cc Huang Shijie ]
> 
> On 03/20/2014 01:29 PM, Felipe Balbi wrote:
> >then we need updates to Documentation:
> >
> >Documentation/serial/tty.txt::
> >
> >|  Driver Side Interfaces:
> >|
> >|  receive_buf()	-	Hand buffers of bytes from the driver to the ldisc
> >|  			for processing. Semantics currently rather
> >|  			mysterious 8(
> >|
> >|  write_wakeup()	-	May be called at any point between open and close.
> >|  			The TTY_DO_WRITE_WAKEUP flag indicates if a call
> >|  			is needed but always races versus calls. Thus the
> >|  			ldisc must be careful about setting order and to
> >|  			handle unexpected calls. Must not sleep.
> >|
> >|  			The driver is forbidden from calling this directly
> >|  			from the ->write call from the ldisc as the ldisc
> >|  			is permitted to call the driver write method from
> >|  			this function. In such a situation defer it.
> >
> >documentation says ldisc is allowed to call ->write() from
> >->write_wakeup(). huh ?
> 
> Patch submitted but never applied.
> 
> http://www.spinics.net/lists/linux-serial/msg11144.html

Thank you. For that patch:

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)