lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Mar 2014 12:40:40 -0700 From: Marcel Holtmann <marcel@...tmann.org> To: Felipe Balbi <balbi@...com> Cc: Greg KH <gregkh@...uxfoundation.org>, linux-serial@...r.kernel.org, linux-bluetooth@...r.kernel.org, Peter Hurley <peter@...leysoftware.com>, m-karicheri2@...com, b32955@...escale.com, Linux OMAP Mailing List <linux-omap@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition Hi Felipe, > LDISCs shouldn't call tty->ops->write() from within > ->write_wakeup(). > > ->write_wakeup() is called with port lock taken and > IRQs disabled, tty->ops->write() will try to acquire > the same port lock and we will deadlock. > > Reviewed-by: Peter Hurley <peter@...leysoftware.com> > Reported-by: Huang Shijie <b32955@...escale.com> > Signed-off-by: Felipe Balbi <balbi@...com> > --- > drivers/bluetooth/hci_ldisc.c | 24 +++++++++++++++++++----- > drivers/bluetooth/hci_uart.h | 1 + > 2 files changed, 20 insertions(+), 5 deletions(-) I hope these are not causing any conflicts with bluetooth-next / linux-next. If not, then I can let Greg take it through tty-next tree. Acked-by: Marcel Holtmann <marcel@...tmann.org> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists