linux-kernel - Re: [PATCH 1/2] sysctl: fix incorrect write position handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKmfp=6VT6uS9025w5DA8NCgFUj1+tQKtM-JgnLqB1UCw@mail.gmail.com>
Date:	Thu, 20 Mar 2014 13:24:14 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Aaron Tomlin <atomlin@...hat.com>,
	Andrew Shewmaker <agshew@...il.com>,
	Li Zefan <lizefan@...wei.com>,
	Dario Faggioli <raistlin@...ux.it>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Wanpeng Li <liwanp@...ux.vnet.ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] sysctl: fix incorrect write position handling

On Wed, Mar 19, 2014 at 6:56 PM, Andi Kleen <ak@...ux.intel.com> wrote:
>>
>> Why are we fixing this?
>
> Also sysctl writes are root only anyways.
>
> Protecting root against root? Seems odd.

I think you misunderstood my motivation. I don't want to protect
anything here except a code auditor's mind. :)

The flaw itself was entirely with Chrome OS and poor filtering of
options that landed in procfs. The failure to recognize the needed
filtering came from the fact that procfs writes behave in an
unexpected manner.

I'd still be curious to see if we could improve things at all without
breaking actual uses. At least some better documentation seems
warranted.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/