linux-kernel - Re: [PATCH 3.10 76/85] Fix mountpoint reference leakage in linkat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140321003816.GA26973@kroah.com>
Date:	Thu, 20 Mar 2014 17:38:16 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Oleg Drokin <green@...uxhacker.ru>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 3.10 76/85] Fix mountpoint reference leakage in linkat

On Thu, Mar 20, 2014 at 08:11:22PM -0400, Oleg Drokin wrote:
> Hello!
> 
> On Mar 20, 2014, at 8:10 PM, Greg Kroah-Hartman wrote:
> 
> > 3.10-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Oleg Drokin <green@...uxhacker.ru>
> > 
> > commit d22e6338db7f613dd4f6095c190682fcc519e4b7 upstream.
> > 
> > Recent changes to retry on ESTALE in linkat
> > (commit 442e31ca5a49e398351b2954b51f578353fdf210)
> > introduced a mountpoint reference leak and a small memory
> > leak in case a filesystem link operation returns ESTALE
> > which is pretty normal for distributed filesystems like
> > lustre, nfs and so on.
> > Free old_path in such a case.
> > 
> > [AV: there was another missing path_put() nearby - on the previous
> > goto retry]
> 
> This comment loses sense in this version because there's no previous goto retry,
> though it might not be important due to it just being a port of an upstream commit, I guess.

True, but it's good to keep history around :)

thanks for the review.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/