lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Mar 2014 08:58:34 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Matt Porter <mporter@...aro.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Tim Kryger <tim.kryger@...aro.org>,
	Markus Mayer <markus.mayer@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] regulator: bcm590xx: Use array to save desc and *info

2014-03-20 23:42 GMT+08:00 Matt Porter <mporter@...aro.org>:
> On Fri, Mar 14, 2014 at 10:00:28AM +0800, Axel Lin wrote:
>> BCM590XX_NUM_REGS is known in compile time.
>> Use array to save desc and *info makes the code simpler.
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>
> Well, ok. It was coded for dynamic allocation because I'm starting to
> work on BCM59054 support, which is similar but different. The actual
> regulators are different but, due to luck, the total number is the
> same between 59056 and 59054...so this can still work for the moment.
> However, another 590xx part does have a different number of regulators
> so I'm not sure this is worth doing when we know we'll go back to
> dynamic allocation in the future.

Then it' ok to keep the code as is, just drop this patch.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists