linux-kernel - Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140321042737.GA4439@kroah.com>
Date:	Thu, 20 Mar 2014 21:27:37 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	nandu.hgowda@...il.com, devel@...verdev.osuosl.org,
	shaun@...source.ca, gulsah.1004@...il.com, sachin.kamat@...aro.org,
	peter.p.waskiewicz.jr@...el.com, ebru.akagunduz@...il.com,
	dulshani.gunawardhana89@...il.com, linux-kernel@...r.kernel.org,
	dhowells@...hat.com, himangi774@...il.com, viro@...iv.linux.org.uk,
	joe@...ches.com, fempsci@...il.com, speiro@....upv.es
Subject: Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with
 kmalloc/kfree

On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote:
> 
> Replace OS_kmalloc/OS_kfree with kmalloc/kfree.

You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed
out the allocated data:


> -static inline void *
> -OS_kmalloc (size_t size)
> -{
> -    char       *ptr = kmalloc (size, GFP_KERNEL | GFP_DMA);
> -
> -    if (ptr)
> -        memset (ptr, 0, size);
> -    return ptr;
> -}

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/