linux-kernel - Re: [PATCH] fix some coding style in drivers/staging/iio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <532BEBCD.3020002@metafoo.de>
Date:	Fri, 21 Mar 2014 08:35:41 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Jimmy Li <coder.liss@...il.com>
CC:	Jonathan Cameron <jic23@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix some coding style in drivers/staging/iio

[...]
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6f38ca9..31c7a9d 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -392,7 +392,8 @@ static const struct iio_info adis16220_info = {
>   };
>
>   static const char * const adis16220_status_error_msgs[] = {
> -	[ADIS16220_DIAG_STAT_VIOLATION_BIT] = "Capture period violation/interruption",
> +	[ADIS16220_DIAG_STAT_VIOLATION_BIT] =
> +		"Capture period violation/interruption",

This does not improve legibility. The 80 chars per line rule is to improve 
legibility, if it doesn't it's better to ignore it.

>   	[ADIS16220_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
>   	[ADIS16220_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
>   	[ADIS16220_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
[...]
> diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
> index 36eedd8..d38df2e 100644
> --- a/drivers/staging/iio/resolver/ad2s1200.c
> +++ b/drivers/staging/iio/resolver/ad2s1200.c
> @@ -70,6 +70,7 @@ static int ad2s1200_read_raw(struct iio_dev *indio_dev,
>   		vel = (((s16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4);
>   		vel = (vel << 4) >> 4;
>   		*val = vel;
> +		/* fall through */

This not a coding style issue, here is actually a break missing.

>   	default:
>   		mutex_unlock(&st->lock);
>   		return -EINVAL;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/