linux-kernel - Re: rb tree hrtimer lockup bug (found by perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403210956000.18573@ionos.tec.linutronix.de>
Date:	Fri, 21 Mar 2014 10:02:53 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Vince Weaver <vincent.weaver@...ne.edu>
cc:	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: rb tree hrtimer lockup bug (found by perf_fuzzer)

On Thu, 20 Mar 2014, Vince Weaver wrote:

> On Thu, 20 Mar 2014, Thomas Gleixner wrote:
> > 
> > Yeah, it causes the explosion in the debug object code. This should
> > have been:
> > 
> > +                       trace_printk("Tracking Object free: %s %p %pS\n",
> > +                                    descr->name, obj->object, obj->hint);
> 
> attached are the results with the corrected patch.

I'm a complete idiot. I was staring at oaddr and did not notice that
descr->name is the real culprit. Sorry. Delta patch below.

Thanks,

	tglx

Index: linux-2.6/lib/debugobjects.c
===================================================================
--- linux-2.6.orig/lib/debugobjects.c
+++ linux-2.6/lib/debugobjects.c
@@ -769,6 +769,7 @@ repeat:
 		/* Now free them */
 		hlist_for_each_entry_safe(obj, tmp, &freelist, node) {
 			hlist_del(&obj->node);
+			descr = obj->descr;
 			trace_printk("Tracking Object free: %s %p %pS\n",
 				     descr->name, obj->object, obj->hint);
 			free_object(obj);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/