[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140321103432.GF15213@lee--X1>
Date: Fri, 21 Mar 2014 10:34:32 +0000
From: Lee Jones <lee.jones@...aro.org>
To: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc: broonie@...nel.org, robh+dt@...nel.org, pawel.moll@....com,
mark.rutland@....com, ijc+devicetree@...lion.org.uk,
galak@...eaurora.org, rob@...dley.net, sameo@...ux.intel.com,
lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] regulator: arizona-ldo1: Add processing of init_data
from device tree
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++
I can see why you're doing it like this, but it's probably best to do
all of the document changes in one single (separate) patch.
> drivers/regulator/arizona-ldo1.c | 46 +++++++++++++++++++-
> 2 files changed, 50 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 36a0c3d..9d54c70 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -42,6 +42,13 @@ Optional properties:
> the chip default will be used. If present exactly five values must
> be specified.
>
> + - ldo1 : Initial data for the LDO1 regulator, as covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt
> +
> + - DCVDD-supply : Power supply, only needs to be specified if DCVDD is being
> + externally supplied. As covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt
> +
Looks fine to me again, but I'd still like a regulator and/or DT guy
to Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists