lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 21 Mar 2014 11:50:40 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jonghwan Choi <jhbird.choi@...sung.com>
Cc:	'open list' <linux-kernel@...r.kernel.org>,
	'Liam Girdwood' <lgirdwood@...il.com>
Subject: Re: [PATCH] regulator: core: Reduce busy-wait looping

On Fri, Mar 21, 2014 at 11:31:25AM +0900, Jonghwan Choi wrote:

> Commit 5df529d440("regulator: core: Reduce busy-wait looping")
> can also be used in regulator_do_set_voltage.

This is good as a change but please factor it out into a function so we
don't have the same problem again with future changes (I'm surprised
there isn't one in the generic code somewhere but if not we can do that
as a second stage, regulator only is fine for now) and make sure that
the lines are less than 80 columns.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists