| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHj3AV=K8XU_Tik6pB4d0E6Mb5f+YhHtn1pEA2hWKqDqCWs8iQ@mail.gmail.com>
Date: Fri, 21 Mar 2014 07:04:07 -0700
From: Denis Kirjanov <kirjanov@...il.com>
To: Matei Oprea <eu@...eamatei.ro>
Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
ROSEdu Kernel Community <firefly@...ts.rosedu.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces
On 3/21/14, Matei Oprea <eu@...eamatei.ro> wrote:
> Fix different address spaces when unmapping IO. hi->addr_mapped[0]
> and hi->addr_mapped[1] should be tagged __iomem.
>
> Signed-off-by: Matei Oprea <eu@...eamatei.ro>
> Cc: ROSEdu Kernel Community <firefly@...ts.rosedu.org>
> ---
> drivers/staging/cxt1e1/hwprobe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/cxt1e1/hwprobe.c
> b/drivers/staging/cxt1e1/hwprobe.c
> index 9b4198b..f55c27e 100644
> --- a/drivers/staging/cxt1e1/hwprobe.c
> +++ b/drivers/staging/cxt1e1/hwprobe.c
> @@ -174,12 +174,12 @@ cleanup_ioremap(void)
> if (hi->pci_slot == 0xff)
> break;
> if (hi->addr_mapped[0]) {
> - iounmap((void *)(hi->addr_mapped[0]));
> + iounmap((void __iomem *)(hi->addr_mapped[0]));
> release_mem_region((long) hi->addr[0], hi->len[0]);
> hi->addr_mapped[0] = 0;
> }
> if (hi->addr_mapped[1]) {
> - iounmap((void *)(hi->addr_mapped[1]));
> + iounmap((void __iomem *)(hi->addr_mapped[1]));
> release_mem_region((long) hi->addr[1], hi->len[1]);
> hi->addr_mapped[1] = 0;
> }
__iomem annotations should be added to the private structure pointers.
Look at the iounmap usage in the drivers.
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
--
Regards,
Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists