linux-kernel - Re: [PATCH] printk: Fix discarding of records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 21 Mar 2014 08:33:08 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Josh Hunt <joshhunt00@...il.com>
Cc:	"Banerjee, Debabrata" <dbanerje@...mai.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jeff Mahoney <jeffm@...e.com>,
	"dbavatar@...il.com" <dbavatar@...il.com>,
	"Hunt, Joshua" <johunt@...mai.com>, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] printk: Fix discarding of records

On Fri, Mar 21, 2014 at 10:18:13AM -0500, Josh Hunt wrote:
> On Sun, Feb 16, 2014 at 8:38 PM, Banerjee, Debabrata
> <dbanerje@...mai.com> wrote:
> > On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@...ux-foundation.org>
> > wrote:
> >
> >>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
> >><dbanerje@...mai.com> wrote:
> >>>
> >>> No that can't be right, the prev value after every loop is the
> >>>msg->flags
> >>> from the *last* line in the list, which has no relation to the *first*,
> >>>so
> >>> reusing it for the top of the next loop is nonsense.
> >>
> >>Please, Debabrata, humor me, and just try the patch.
> >>
> >>And try reading the source code. Because your statement is BS.
> > ...
> >>No, I haven't tested my patch, and maybe it's broken for some subtle
> >>reason I'm missing too.
> >
> > Yes my explanation was wrong, your patch works for me. I assumed printing
> > the prefix was desired, but if not, great.
> 
> The resulting patch from this discussion:
> 
> commit e4178d809fdaee32a56833fff1f5056c99e90a1a
> Author: Linus Torvalds <torvalds@...ux-foundation.org>
> Date:   Mon Feb 17 12:24:45 2014 -0800
> 
>     printk: fix syslog() overflowing user buffer
> 
> has not made it into stable yet. Can we add it to the stable queue?
> I'm not sure if it needs more bake time, etc.

I'll queue it up for the next round of stable releases after this one,
thanks for pointing it out.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/