linux-kernel - Re: [PATCH v7 2/2] Tracepoint: register/unregister struct tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140321154000.19939515@gandalf.local.home>
Date:	Fri, 21 Mar 2014 15:40:00 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH v7 2/2] Tracepoint: register/unregister struct
 tracepoint

On Fri, 21 Mar 2014 01:19:02 -0400

> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index 4e4cc28..1592c1c 100644
> --- a/include/linux/ftrace_event.h
> +++ b/include/linux/ftrace_event.h
> @@ -230,6 +230,7 @@ struct ftrace_event_call {
>  	struct list_head	list;
>  	struct ftrace_event_class *class;
>  	char			*name;
> +	struct tracepoint	*tp;


This change right here just added 17K to the kernel (on a minimum config):

   text	   data	    bss	    dec	    hex	filename
8425515	2018936	1302528	11746979	 b33ea3	vmlinux.orig
8424914	2036472	1302528	11763914	 b380ca	vmlinux

The two are redundant. Might as well remove .name and then
use .tp->name for referencing the name of the event.

-- Steve


>  	struct trace_event	event;
>  	const char		*print_fmt;
>  	struct event_filter	*filter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/