linux-kernel - Re: [PATCH] x86: LLVMLinux: Fix "incomplete type const struct x86cpu_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140322162808.GF13385@kroah.com>
Date:	Sat, 22 Mar 2014 09:28:08 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	behanw@...verseincode.com
Cc:	dh.herrmann@...il.com, sameo@...ux.intel.com,
	jani.nikula@...el.com, alexandre.bounine@....com,
	akpm@...ux-foundation.org, dmitry.torokhov@...il.com,
	tomas.winkler@...el.com, arnd@...db.de,
	linux-kernel@...r.kernel.org, dwmw2@...radead.org,
	pageexec@...email.hu,
	Jan-Simon Möller <dl9pf@....de>
Subject: Re: [PATCH] x86: LLVMLinux: Fix "incomplete type const struct
 x86cpu_device_id"

On Fri, Mar 21, 2014 at 11:40:18PM -0700, behanw@...verseincode.com wrote:
> From: Behan Webster <behanw@...verseincode.com>
> 
> Similar to the fix in 40413dcb7b273bda681dca38e6ff0bbb3728ef11
> 
> MODULE_DEVICE_TABLE(x86cpu, ...) expects the struct to be called struct
> x86cpu_device_id, and not struct x86_cpu_id which is what is used in the rest
> of the kernel code.  Although gcc seems to ignore this error, clang fails
> without this define to fix the name.
> 
> Code from drivers/thermal/x86_pkg_temp_thermal.c
> static const struct x86_cpu_id __initconst pkg_temp_thermal_ids[] = { ... };
> MODULE_DEVICE_TABLE(x86cpu, pkg_temp_thermal_ids);
> 
> Error from clang:
> drivers/thermal/x86_pkg_temp_thermal.c:577:1: error: variable has
>       incomplete type 'const struct x86cpu_device_id'
> MODULE_DEVICE_TABLE(x86cpu, pkg_temp_thermal_ids);
> ^
> include/linux/module.h:145:3: note: expanded from macro
>       'MODULE_DEVICE_TABLE'
>   MODULE_GENERIC_TABLE(type##_device, name)
>   ^
> include/linux/module.h:87:32: note: expanded from macro
>       'MODULE_GENERIC_TABLE'
> extern const struct gtype##_id __mod_##gtype##_table            \
>                                ^
> <scratch space>:143:1: note: expanded from here
> __mod_x86cpu_device_table
> ^
> drivers/thermal/x86_pkg_temp_thermal.c:577:1: note: forward declaration of
>       'struct x86cpu_device_id'
> include/linux/module.h:145:3: note: expanded from macro
>       'MODULE_DEVICE_TABLE'
>   MODULE_GENERIC_TABLE(type##_device, name)
>   ^
> include/linux/module.h:87:21: note: expanded from macro
>       'MODULE_GENERIC_TABLE'
> extern const struct gtype##_id __mod_##gtype##_table            \
>                     ^
> <scratch space>:141:1: note: expanded from here
> x86cpu_device_id
> ^
> 1 error generated.
> 
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> Signed-off-by: Jan-Simon Möller <dl9pf@....de>

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/