linux-kernel - Re: [PATCH] arch/unicore32/kernel/ksyms.c: remove several undefined exported symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2016503893.2147.1395472703720.JavaMail.root@bj-mail03.pku.edu.cn>
Date:	Sat, 22 Mar 2014 15:18:23 +0800 (CST)
From:	管雪涛 <gxt@....edu.cn>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	gxt@...c.pku.edu.cn, linux-kernel@...r.kernel.org,
	sunzhichuang@...c.pku.edu.cn
Subject: Re: [PATCH] arch/unicore32/kernel/ksyms.c: remove several undefined
 exported symbols

Thanks Chen.
Need I add these patches to unicore32 repo?

Cc: Zhichuang Sun <sunzhichuang@...c.pku.edu.cn>
Tested-by: Zhichuang Sun <sunzhichuang@...c.pku.edu.cn>
Acked-by: Xuetao Guan <gxt@....edu.cn>

----- Chen Gang <gang.chen.5i5j@...il.com> 写道：
> For 'csum_partial_copy_nocheck()', it has default definition in
> 'asm-generic'.
> 
> For '__raw_reads?()' and '__raw_writes?()' are used by the drivers
> which no relationship with allmodconfig for unicode32, the related
> modules are:
> 
>   drivers/mmc/host/omap.c
>   drivers/mtd/nand/atmel_nand.c
>   drivers/mtd/nand/pxa3xx_nand.c
>   drivers/usb/gadget/at91_udc.c
> 
> Others are only within some architectures (not kernel wide).
> 
> 
> The related error with allmodconfig for unicode32:
> 
>     CC      arch/unicore32/kernel/ksyms.o
>   arch/unicore32/kernel/ksyms.c:29: error: ‘__backtrace’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:29: error: type defaults to ‘int’ in declaration of ‘__backtrace’
>   arch/unicore32/kernel/ksyms.c:38: error: ‘csum_partial_copy_nocheck’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:38: error: type defaults to ‘int’ in declaration of ‘csum_partial_copy_nocheck’
>   arch/unicore32/kernel/ksyms.c:39: error: ‘__csum_ipv6_magic’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:39: error: type defaults to ‘int’ in declaration of ‘__csum_ipv6_magic’
>   arch/unicore32/kernel/ksyms.c:43: error: ‘__raw_readsb’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:43: error: type defaults to ‘int’ in declaration of ‘__raw_readsb’
>   arch/unicore32/kernel/ksyms.c:46: error: ‘__raw_readsw’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:46: error: type defaults to ‘int’ in declaration of ‘__raw_readsw’
>   arch/unicore32/kernel/ksyms.c:49: error: ‘__raw_readsl’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:49: error: type defaults to ‘int’ in declaration of ‘__raw_readsl’
>   arch/unicore32/kernel/ksyms.c:52: error: ‘__raw_writesb’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:52: error: type defaults to ‘int’ in declaration of ‘__raw_writesb’
>   arch/unicore32/kernel/ksyms.c:55: error: ‘__raw_writesw’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:55: error: type defaults to ‘int’ in declaration of ‘__raw_writesw’
>   arch/unicore32/kernel/ksyms.c:58: error: ‘__raw_writesl’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:58: error: type defaults to ‘int’ in declaration of ‘__raw_writesl’
>   arch/unicore32/kernel/ksyms.c:79: error: ‘__get_user_1’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:79: error: type defaults to ‘int’ in declaration of ‘__get_user_1’
>   arch/unicore32/kernel/ksyms.c:80: error: ‘__get_user_2’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:80: error: type defaults to ‘int’ in declaration of ‘__get_user_2’
>   arch/unicore32/kernel/ksyms.c:81: error: ‘__get_user_4’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:81: error: type defaults to ‘int’ in declaration of ‘__get_user_4’
>   arch/unicore32/kernel/ksyms.c:83: error: ‘__put_user_1’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:83: error: type defaults to ‘int’ in declaration of ‘__put_user_1’
>   arch/unicore32/kernel/ksyms.c:84: error: ‘__put_user_2’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:84: error: type defaults to ‘int’ in declaration of ‘__put_user_2’
>   arch/unicore32/kernel/ksyms.c:85: error: ‘__put_user_4’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:85: error: type defaults to ‘int’ in declaration of ‘__put_user_4’
>   arch/unicore32/kernel/ksyms.c:86: error: ‘__put_user_8’ undeclared here (not in a function)
>   arch/unicore32/kernel/ksyms.c:86: error: type defaults to ‘int’ in declaration of ‘__put_user_8’
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/unicore32/kernel/ksyms.c |   33 ---------------------------------
>  1 file changed, 33 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index d285d71..63afc7f 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -26,8 +26,6 @@
>  EXPORT_SYMBOL(find_next_zero_bit);
>  EXPORT_SYMBOL(find_next_bit);
>  
> -EXPORT_SYMBOL(__backtrace);
> -
>  	/* platform dependent support */
>  EXPORT_SYMBOL(__udelay);
>  EXPORT_SYMBOL(__const_udelay);
> @@ -35,28 +33,6 @@ EXPORT_SYMBOL(__const_udelay);
>  	/* networking */
>  EXPORT_SYMBOL(csum_partial);
>  EXPORT_SYMBOL(csum_partial_copy_from_user);
> -EXPORT_SYMBOL(csum_partial_copy_nocheck);
> -EXPORT_SYMBOL(__csum_ipv6_magic);
> -
> -	/* io */
> -#ifndef __raw_readsb
> -EXPORT_SYMBOL(__raw_readsb);
> -#endif
> -#ifndef __raw_readsw
> -EXPORT_SYMBOL(__raw_readsw);
> -#endif
> -#ifndef __raw_readsl
> -EXPORT_SYMBOL(__raw_readsl);
> -#endif
> -#ifndef __raw_writesb
> -EXPORT_SYMBOL(__raw_writesb);
> -#endif
> -#ifndef __raw_writesw
> -EXPORT_SYMBOL(__raw_writesw);
> -#endif
> -#ifndef __raw_writesl
> -EXPORT_SYMBOL(__raw_writesl);
> -#endif
>  
>  	/* string / mem functions */
>  EXPORT_SYMBOL(strchr);
> @@ -76,15 +52,6 @@ EXPORT_SYMBOL(__copy_from_user);
>  EXPORT_SYMBOL(__copy_to_user);
>  EXPORT_SYMBOL(__clear_user);
>  
> -EXPORT_SYMBOL(__get_user_1);
> -EXPORT_SYMBOL(__get_user_2);
> -EXPORT_SYMBOL(__get_user_4);
> -
> -EXPORT_SYMBOL(__put_user_1);
> -EXPORT_SYMBOL(__put_user_2);
> -EXPORT_SYMBOL(__put_user_4);
> -EXPORT_SYMBOL(__put_user_8);
> -
>  EXPORT_SYMBOL(__ashldi3);
>  EXPORT_SYMBOL(__ashrdi3);
>  EXPORT_SYMBOL(__divsi3);
> -- 
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/