linux-kernel - Re: [PATCH] usb: musb: Fix obex in g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Mar 2014 01:45:44 +0100
From:	Rabin Vincent <rabin@....in>
To:	balbi@...com, Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	pali.rohar@...il.com, pavel@....cz, linux-usb@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: Fix obex in g_nokia.ko causing kernel panic

2014-02-06 20:25 GMT+01:00 Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>:
> From: Felipe Balbi <balbi@...com>

This patch, which is present in 3.14-rc4 as 30a70b026 ("usb: musb: fix
obex in g_nokia.ko causing kernel panic"), breaks USB gadget support
on my Pandaboard.  Bisecting points to this commit, reverting it makes
USB gadget support work again.  The problem is that this patch deletes
the call which turns on the PHY.

Config is attached.

> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 2a408cd..8aa59a2 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -659,7 +659,6 @@ static int omap2430_runtime_suspend(struct device *dev)
>                                 OTG_INTERFSEL);
>
>                 omap2430_low_level_exit(musb);
> -               phy_power_off(musb->phy);
>         }
>
>         return 0;
> @@ -674,7 +673,6 @@ static int omap2430_runtime_resume(struct device *dev)
>                 omap2430_low_level_init(musb);
>                 musb_writel(musb->mregs, OTG_INTERFSEL,
>                                 musb->context.otg_interfsel);
> -               phy_power_on(musb->phy);
>         }
>
>         return 0;

Download attachment "panda-usb-config.gz" of type "application/x-gzip" (1982 bytes)