linux-kernel - Re: [PATCH] mtd: diskonchip: mem resource name is not optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395477572.57478225@f224.i.mail.ru>
Date:	Sat, 22 Mar 2014 12:39:32 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	computersforpeace@...il.com
Subject: Re: [PATCH] mtd: diskonchip: mem resource name is not optional

Wed, 19 Mar 2014 18:24:37 -0400 от Sasha Levin <sasha.levin@...cle.com>:
> Passing a name to request_mem_region() isn't optional and can't just
> be NULL. Passing NULL causes a NULL ptr deref later in the boot
> process.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>  drivers/mtd/nand/diskonchip.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c
> index b9b4db6..f68a7bc 100644
> --- a/drivers/mtd/nand/diskonchip.c
> +++ b/drivers/mtd/nand/diskonchip.c
> @@ -1439,7 +1439,7 @@ static int __init doc_probe(unsigned long physadr)
>  	int reg, len, numchips;
>  	int ret = 0;
>  
> -	if (!request_mem_region(physadr, DOC_IOREMAP_LEN, NULL))
> +	if (!request_mem_region(physadr, DOC_IOREMAP_LEN, "DiskOnChip"))
>  		return -EBUSY;
>  	virtadr = ioremap(physadr, DOC_IOREMAP_LEN);
>  	if (!virtadr) {
> -- 

Tested-by: Alexander Shiyan <shc_work@...l.ru>

---