linux-kernel - Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201403221101.16961.arnd@arndb.de>
Date:	Sat, 22 Mar 2014 11:01:16 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	behanw@...verseincode.com
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	dwmw2@...radead.org, pageexec@...email.hu,
	Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH] LLVMLinux: Remove warning about returning an uninitialized variable

On Saturday 22 March 2014, behanw@...verseincode.com wrote:
> diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h
> index d8d4c89..4c41bb8 100644
> --- a/include/asm-generic/cmpxchg-local.h
> +++ b/include/asm-generic/cmpxchg-local.h
> @@ -41,6 +41,7 @@ static inline unsigned long __cmpxchg_local_generic(volatile void *ptr,
>                 break;
>         default:
>                 wrong_size_cmpxchg(ptr);
> +               prev = 0;
>         }
>         raw_local_irq_restore(flags);
>         return prev;


How about using __unreachable() instead to annotate the fact that you won't
get here?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/