linux-kernel - Re: [PATCH v4 0/4] Provide netdev naming-policy via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4Rb=gqmo+9xGnuC9N2gWb2TqOskaMDhFU9wn28z+HZa4g@mail.gmail.com>
Date:	Mon, 24 Mar 2014 09:59:18 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>, Tom Gundersen <teg@...m.no>,
	Johannes berg <johannes@...solutions.net>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David Herrmann <dh.herrmann@...il.com>
Subject: Re: [PATCH v4 0/4] Provide netdev naming-policy via sysfs

Hi Dave

Any comments on this?

Thanks
David

On Mon, Mar 17, 2014 at 8:42 PM, David Herrmann <dh.herrmann@...il.com> wrote:
> Hi
>
> This is v4 of the netdev naming-policy series. You can find v1 here:
>   http://thread.gmane.org/gmane.linux.kernel/1657015
> Changes since v1:
>   - fix mac80211 core to set NET_NAME_ENUM for wlan%d kernel-provided names
>   - acked-by udev developers
>   - avoid padding after name_assign_type in "struct net_device" (David Laight)
>   - move API constants to uapi header (Ben Hutchings)
>
>
> This series implements a new sysfs attribute for netdevs called
> "name_assign_type". It provides an integer that describes where an interface
> name comes from. See Patch #1 for a description of this attribute. It is
> modelled after the existing "addr_assign_type" attribute.
>
> The main use-case is to allow udev to skip applying reliable ifnames to virtual
> devices. For instance, if wifi-P2P devices are created, wpas already provides a
> suitable naming-policy and udev shouldn't touch these devices. Same is true for
> other virtual devices.
> The idea is that if a device-name was provided by user-space, we should always
> prefer fixing this naming-policy instead of making udev rename the device. For
> kernel provided names that's hardly possible, though. Providing the
> naming-policy source via sysfs is thus a simple way to see whether renames are
> needed.
>
> Additionally, this field allows to detect whether a netdev has been manually
> renamed, which is quite useful for debugging and during crash-recovery.
> Furthermore, it fixes real udev bugs if a netdev is already renamed in the
> initrd and udev only runs in the real root. Detecting renames avoids overwriting
> custom user provided names.
>
> Thanks
> David
>
> David Herrmann (4):
>   net: add name_assign_type netdev attribute
>   mac80211: set NET_NAME_USER for user-space created ifs
>   ath6kl: set NET_NAME_USER for P2P ifs
>   brcmfmac: set NET_NAME_USER for P2P ifs
>
>  drivers/net/wireless/ath/ath6kl/cfg80211.c    | 5 ++++-
>  drivers/net/wireless/ath/ath6kl/cfg80211.h    | 1 +
>  drivers/net/wireless/ath/ath6kl/core.c        | 4 ++--
>  drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 1 +
>  include/linux/netdevice.h                     | 2 ++
>  include/uapi/linux/netdevice.h                | 4 ++++
>  net/core/dev.c                                | 7 +++++++
>  net/core/net-sysfs.c                          | 2 ++
>  net/core/rtnetlink.c                          | 2 ++
>  net/mac80211/cfg.c                            | 2 +-
>  net/mac80211/ieee80211_i.h                    | 1 +
>  net/mac80211/iface.c                          | 2 ++
>  net/mac80211/main.c                           | 2 +-
>  13 files changed, 30 insertions(+), 5 deletions(-)
>
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/