linux-kernel - Re: [PATCH -tip v8 08/26] kprobes/x86: Call exception handlers directly from do_int3/do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140324145815.1de836af@gandalf.local.home>
Date:	Mon, 24 Mar 2014 14:58:15 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Andi Kleen <andi@...stfloor.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Sandeepa Prabhu <sandeepa.prabhu@...aro.org>,
	Frederic Weisbecker <fweisbec@...il.com>, x86@...nel.org,
	fche@...hat.com, mingo@...hat.com, systemtap@...rceware.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -tip v8 08/26] kprobes/x86: Call exception handlers
 directly from do_int3/do_debug

On Mon, 24 Mar 2014 17:47:06 +0900
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

> >> @@ -857,7 +857,7 @@ no_change:
> >>   * Interrupts are disabled on entry as trap1 is an interrupt gate and they
> >>   * remain disabled throughout this function.
> >>   */
> >> -static int __kprobes post_kprobe_handler(struct pt_regs *regs)
> >> +int __kprobes kprobe_debug_handler(struct pt_regs *regs)


> >> -		break;
> >> -	case DIE_DEBUG:
> >> -		if (post_kprobe_handler(args->regs)) {

> > 
> > The DIE_DEBUG case is removed but not added anyplace else. The change
> > log doesn't say why this was removed.
> 
> As you can see the above hunk, post_kprobe_handler() is now renamed
> as kprobe_debug_handler() which is called from do_debug() directly.
> 
> What I meant in the patch comment;
> 
> >> To avoid a kernel crash by probing on lockdep code, call
> >> kprobe_int3_handler and kprobe_debug_handler directly
> >> from do_int3 and do_debug.
> 
> was actually pointing that change...
> 


I missed the rename of post_kprobe_handler().

Reviewed-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/