[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <532FA61C.7070601@roeck-us.net>
Date: Sun, 23 Mar 2014 20:27:24 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>,
Jean Delvare <jdelvare@...e.de>
CC: David Dajun Chen <david.chen@...semi.com>,
LINUX-DOC <linux-doc@...r.kernel.org>,
LINUX-KERNEL <linux-kernel@...r.kernel.org>,
LM-SENSORS <lm-sensors@...sensors.org>,
Lee Jones <lee.jones@...aro.org>,
Mark Brown <broonie@...aro.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Rob Landley <rob@...dley.net>,
Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [RFC V1 1/3] hwmon: da9063: HWMON driver
On 03/23/2014 01:37 PM, Opensource [Steve Twiss] wrote:
> From: Opensource [Steve Twiss] <stwiss.opensource@...semi.com>
>
> Add the HWMON driver for DA9063
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@...semi.com>
> ---
> +
> + ret = sysfs_create_group(&pdev->dev.kobj, &da9063_attr_group);
> + if (ret)
> + return ret;
> +
> + hwmon->classdev = hwmon_device_register(&pdev->dev);
> + if (IS_ERR(hwmon->classdev)) {
> + sysfs_remove_group(&pdev->dev.kobj, &da9063_attr_group);
> + return PTR_ERR(hwmon->classdev);
> + }
> +
Hi Steve,
This looks like an ideal candidate for devm_hwmon_device_register_with_groups().
Can you use that API, please ?
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists