linux-kernel - Re: [PATCH] staging: line6: Fix missing blanks after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395696913.13968.67.camel@joe-AO722>
Date:	Mon, 24 Mar 2014 14:35:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Mewes <architekt@...ing4coffee.org>
Cc:	gregkh@...uxfoundation.org, ashvinivaratharaj@...il.com,
	cbajumpa@...il.com, rashika.kheria@...il.com,
	berardi.dav@...il.com, monamagarwal123@...il.com,
	lisa@...apiadmin.com, ebru.akagunduz@...il.com, stefanha@...il.com,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: line6: Fix missing blanks after declarations

On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote:
> This patch is part of eudyptula challenge task 10
> 
> Signed-off-by: Fabian Mewes <architekt@...ing4coffee.org>

Hi Fabian.

The patch seems fine, but please do not use something
like the above as a commit message.

It would be better to describe _why_ the change should
be done.  Something like:

------

Subject: [PATCH] staging: line6: Add blank lines after declarations

Use the more common kernel coding style.

Signed-off-by: your name <your.email@...ain.tld>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/