linux-kernel - Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53315B83.2060509@hitachi.com>
Date:	Tue, 25 Mar 2014 19:33:39 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Andi Kleen <andi@...stfloor.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Sandeepa Prabhu <sandeepa.prabhu@...aro.org>,
	Frederic Weisbecker <fweisbec@...il.com>, x86@...nel.org,
	Oleg Nesterov <oleg@...hat.com>, fche@...hat.com,
	mingo@...hat.com,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Seiji Aguchi <seiji.aguchi@....com>, systemtap@...rceware.org,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>
Subject: Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of __kprobes
 annotation

(2014/03/25 4:45), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:21 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
>   
>>  /*
>>   * This is gone through when something in the kernel has done something bad
>> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
>> index ae5aafb..d00103a 100644
>> --- a/arch/x86/kernel/kprobes/core.c
>> +++ b/arch/x86/kernel/kprobes/core.c
>> @@ -112,7 +112,8 @@ struct kretprobe_blackpoint kretprobe_blacklist[] = {
>>  
>>  const int kretprobe_blacklist_size = ARRAY_SIZE(kretprobe_blacklist);
>>  
>> -static void __kprobes __synthesize_relative_insn(void *from, void *to, u8 op)
>> +static nokprobe_inline
>> +void __synthesize_relative_insn(void *from, void *to, u8 op)
> 
> I believe the proper way to break this up is:
> 
> static nokprobe_inline void
> __synthesize_relative_insn(...)

Oops, there are so many incorrect style hunks...:( I'll fix those.

Thank you!


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/