linux-kernel - Re: [PATCH v9 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Mar 2014 11:19:55 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	<Marc.Zyngier@....com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"konrad.wilk@...cle.com" <konrad.wilk@...cle.com>,
	Will Deacon <Will.Deacon@....com>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"olof@...om.net" <olof@...om.net>, "arnd@...db.de" <arnd@...db.de>,
	"nico@...aro.org" <nico@...aro.org>,
	"cov@...eaurora.org" <cov@...eaurora.org>,
	<catalin.marinas@....com>
Subject: Re: [PATCH v9 4/5] arm64: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING
 and pv_time_ops

On Mon, 17 Feb 2014, Catalin Marinas wrote:
> On Mon, Feb 17, 2014 at 12:25:42PM +0000, Stefano Stabellini wrote:
> > On Thu, 9 Jan 2014, Stefano Stabellini wrote:
> > > Introduce CONFIG_PARAVIRT and PARAVIRT_TIME_ACCOUNTING on ARM64.
> > > Necessary duplication of paravirt.h and paravirt.c with ARM.
> > > 
> > > The only paravirt interface supported is pv_time_ops.steal_clock, so no
> > > runtime pvops patching needed.
> > > 
> > > This allows us to make use of steal_account_process_tick for stolen
> > > ticks accounting.
> > > 
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > > CC: will.deacon@....com
> > > CC: nico@...aro.org
> > > CC: marc.zyngier@....com
> > > CC: cov@...eaurora.org
> > > CC: arnd@...db.de
> > > CC: olof@...om.net
> > > CC: Catalin.Marinas@....com
> > 
> > Catalin, Will, are you happy with this patch for 3.15?
> 
> It's pretty small and looks fine to me. However, I would like someone
> with more virtualisation experience than me to ack it (e.g. Marc Z).

Ping? Marc, could you please give it a review?


> Some nitpicks:
> 
> > > +config PARAVIRT
> > > +	bool "Enable paravirtualization code"
> > > +	---help---
> > > +	  This changes the kernel so it can modify itself when it is run
> > > +	  under a hypervisor, potentially improving performance significantly
> > > +	  over full virtualization.
> > > +
> > > +config PARAVIRT_TIME_ACCOUNTING
> > > +	bool "Paravirtual steal time accounting"
> > > +	select PARAVIRT
> > > +	default n
> > > +	---help---
> 
> For consistency with this file, just use "help" rather than
> "---help---".
> 
> > > --- /dev/null
> > > +++ b/arch/arm64/include/asm/paravirt.h
> > > @@ -0,0 +1,20 @@
> > > +#ifndef _ASM_ARM64_PARAVIRT_H
> > > +#define _ASM_ARM64_PARAVIRT_H
> 
> __ASM_PARAVIRT_H for consistency.
> 
> -- 
> Catalin
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/